Project

General

Profile

Feature #988

charmrun should not ignore +ppn

Added by Nikhil Jain over 3 years ago. Updated 11 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
02/22/2016
Due date:
% Done:

0%


Description

In net/verbs layer, it seems like passing +ppn to charmrun does not have any effect.

History

#1 Updated by Sam White over 1 year ago

  • Assignee changed from Eric Mikida to Evan Ramos

Reassigning to Evan since he's been working on charmrun

#2 Updated by Evan Ramos over 1 year ago

++ppn (two pluses) is working fine. Should +ppn (one plus) work in the same circumstances as ++ppn?

#3 Updated by Evan Ramos over 1 year ago

  • Status changed from New to Feedback

#4 Updated by Evan Ramos over 1 year ago

  • Status changed from Feedback to Rejected

#5 Updated by Jim Phillips over 1 year ago

Rejected why? Does charmrun silently ignore +ppn? It should either accept it or throw an error.

#6 Updated by Evan Ramos over 1 year ago

  • Status changed from Rejected to New

#7 Updated by Evan Ramos over 1 year ago

  • Priority changed from High to Normal
  • Tracker changed from Bug to Feature

The convention for command line arguments appears to be that options with a single plus "+" are reserved for the Charm runtime system to handle as part of the node program, while two-plus "++" options belong to Charmrun. Charmrun's argument passing code makes an exception for arguments a single character long, and "+p" is currently the only single-character argument. "+ppn" with one plus has never been a part of Charmrun's vocabulary. This is how things stand as of Charm master today, assuming netlrts or verbs:

Charm standalone, non-SMP
+p --> (error)
++p --> (error)
+ppn --> (error)
++ppn --> (error)

Charmrun, non-SMP
+p --> total PEs = total nodes
++p --> total PEs = total nodes
+ppn --> (error)
++ppn --> (error)

Charm standalone, SMP
+p --> total PEs = PEs per node
++p --> (error)
+ppn --> total PEs = PEs per node
++ppn --> total PEs = PEs per node

Charmrun, SMP
+p --> total PEs
++p --> total PEs
+ppn --> (error)
++ppn --> PEs per node

I don't know if the intent behind Charmrun's support for one-plus "+p" is an ease of use feature for users, or more akin to the GNU convention of "-" for single characters and "--" for multiple. I am not sure of the value of adding support for "+ppn", since pairs of +p and ++ppn values do not mean the same thing between standalone and Charmrun.

#8 Updated by Jim Phillips over 1 year ago

Producing an error is sufficient. Silently ignoring an option is not.

The confusion is that platforms that don't use charmrun (IBM, Cray, MPI, OFI) require passing +ppn to the application binary.

#9 Updated by Evan Ramos over 1 year ago

  • Status changed from New to Resolved

If an error is sufficient, I am marking this resolved.

#10 Updated by Evan Ramos over 1 year ago

  • Status changed from Resolved to Closed

#11 Updated by Evan Ramos 11 months ago

  • Target version set to 6.9.0

Also available in: Atom PDF