Project

General

Profile

Cleanup #960

Replace CmiEnforce(0) calls in verbs and net layer

Added by Michael Robson over 3 years ago. Updated over 2 years ago.

Status:
Merged
Priority:
Normal
Assignee:
Category:
Machine Layers
Target version:
Start date:
01/21/2016
Due date:
% Done:

0%


Description

See [[https://charm.cs.illinois.edu/gerrit/#/c/966/]] for discussion. Copying some relevant bits here.

Phil: All of the 'CmiEnforce(0);' calls should be CmiAbort calls with an associated failure description. It never, ever makes sense to assert or enforce logical false.

Jim: Yes, they should be, but my goal was to improve the code via low-risk mechanical substitution that would not require testing. I'm more concerned with CmiAssert being a no-op than a poor error message.


Related issues

Related to Charm++ - Bug #926: hangs on verbs error Closed 12/17/2015

History

#1 Updated by Nikhil Jain over 3 years ago

  • Assignee set to Prateek Jindal

#2 Updated by Sam White almost 3 years ago

  • Assignee deleted (Prateek Jindal)

#3 Updated by Sam White over 2 years ago

  • Assignee set to Jaemin Choi
  • Target version set to 6.8.1
  • Category set to Machine Layers

#4 Updated by Jaemin Choi over 2 years ago

So what do you want me to do here?
Replace CmiEnforce(0) with CmiAbort()?

#5 Updated by Jaemin Choi over 2 years ago

  • Subject changed from Replace CmiEnforce(0) calls in verbs layer to Replace CmiEnforce(0) calls in verbs and net layer
  • Status changed from New to Implemented

There were CmiEnforce(0) calls in the net layer, so also replaced those.

#6 Updated by Phil Miller over 2 years ago

  • translation missing: en.field_closed_date set to 2017-02-07 17:10:32.603370
  • Status changed from Implemented to Merged

#7 Updated by Phil Miller over 2 years ago

  • Target version changed from 6.8.1 to 6.8.0

Also available in: Atom PDF