Project

General

Profile

Bug #937

[local] entry methods don't set tracing event dependencies

Added by Phil Miller over 2 years ago. Updated 10 days ago.

Status:
Implemented
Priority:
High
Assignee:
Category:
Tracing
Target version:
Start date:
01/03/2016
Due date:
% Done:

0%


Description

When calling a [local] method of a group or array element, we get a distinct trace event for the time spent in the called object. However, that event's dependency field is left unset, meaning that traceback will lose its trail at these events.

At present, look in src/xlat-i/xi-Entry.C methods genGroupDefs and genArrayDefs. Per #921, I may be moving this code into virtual methods on ArrayElement and @Group.


Related issues

Related to Charm++ - Feature #921: Entry tag [inline] is unable to optimize away most of the overhead Implemented 12/14/2015
Duplicates Projections - Bug #459: inline and local entry method can not be tracked back New 04/02/2014

History

#1 Updated by Eric Bohm over 2 years ago

  • Assignee set to Ronak Buch

#2 Updated by Phil Miller about 2 years ago

  • Priority changed from Normal to High

Necessary change is in xi-Entry.C in Entry::genArrayDefs and analogs for chare/group/nodegroup entry methods.

At least in the array case, one fix will address both [inline] and [local] methods, because the code is factored out to be common (from my changes for #921). All I don't know in terms of how to fix this is the right way to get the right event ID to pass in.

#3 Updated by Sam White over 1 year ago

  • Category set to Tracing

#4 Updated by Phil Miller over 1 year ago

  • Target version changed from 6.8.0 to 6.8.1

#5 Updated by Eric Bohm 11 months ago

  • Target version changed from 6.8.1 to 6.9.0

#6 Updated by Phil Miller 8 months ago

Seonmyeong, you may be in a good position to address this quickly. If so, please re-assign it to yourself.

#7 Updated by Seonmyeong Bak 8 months ago

  • Assignee changed from Ronak Buch to Seonmyeong Bak

#8 Updated by Seonmyeong Bak 5 months ago

  • Status changed from New to In Progress

#9 Updated by Seonmyeong Bak 5 months ago

Similar to the CthThread and CkLoop tracing issue. (eventID is set 0 )

For local methods (or inline), we may set a Cpv vaariable for these local invocation. The variable contain PE local event ID which can be used by local method invocations.

#10 Updated by Seonmyeong Bak 5 months ago

  • Status changed from In Progress to Implemented

#12 Updated by Sam White 5 months ago

Does this also fix bug #459?

#13 Updated by Sam White 4 months ago

Bump

#14 Updated by Sam White 3 months ago

  • Status changed from Implemented to In Progress

This is one of two remaining bugs targeted at v6.9.0

#15 Updated by Sam White 2 months ago

  • Assignee changed from Seonmyeong Bak to Ronak Buch

#16 Updated by Ronak Buch 10 days ago

  • Status changed from In Progress to Implemented

https://charm.cs.illinois.edu/gerrit/#/c/charm/+/3723/ (same link as before, it has just been updated to work for recursive calls and to make the sender accurate).

Also available in: Atom PDF