Project

General

Profile

Bug #805

SDAG tracing counts time waiting for a when to be satisfied as overhead

Added by Eric Mikida almost 4 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Tracing
Target version:
Start date:
08/13/2015
Due date:
% Done:

0%


Description

When a when block is unsatisfied, SDAG still traces it as SDAG overhead, even though at this point the runtime is free to do other things. Tracing of SDAG overhead should stop when a when goes unsatisfied.

History

#1 Updated by Jonathan Lifflander almost 4 years ago

  • Status changed from New to Implemented

Fix has been implemented. Needs to undergo testing.

#2 Updated by Phil Miller almost 4 years ago

I don't see the patch posted on Gerrit. Could you push it and post a link?

#3 Updated by Phil Miller almost 4 years ago

Could we get that patch posted for review & integration? It'd be nice to have it integrated before 6.7, if it's already done.

#4 Updated by Phil Miller over 3 years ago

Ping - please post the patch.

#5 Updated by Jonathan Lifflander over 3 years ago

Working on putting together the patch.

#6 Updated by Phil Miller over 3 years ago

Ping. Is there a fix for this? Even if it's only partial, we can hand that off to someone else to finish up.

#7 Updated by Phil Miller over 3 years ago

  • Target version set to 6.7.1

#8 Updated by Phil Miller over 3 years ago

Ping, again. Is there actually fixed code for this sitting in a repository somewhere, or is that still a work in progress?

#9 Updated by Sam White over 3 years ago

What's the status of this?

#10 Updated by Sam White over 3 years ago

Jonathan said he has a partial fix but that it wasn't entirely correct, so he'll look at it again.

#11 Updated by Sam White over 3 years ago

  • Status changed from Implemented to In Progress

#12 Updated by Sam White over 3 years ago

  • Target version changed from 6.7.1 to 6.8.0

#13 Updated by Eric Bohm almost 3 years ago

  • Assignee changed from Jonathan Lifflander to Eric Mikida

#14 Updated by Sam White over 2 years ago

  • Category set to Tracing
  • Status changed from In Progress to New

#15 Updated by Eric Mikida over 2 years ago

  • Tags set to SDAG, tracing, charmxi

#16 Updated by Eric Mikida over 2 years ago

  • Status changed from New to Closed

I can't seem to reproduce this bug, and the code looks pretty sound from what I can tell. The only way TRACE_EXECUTE_BEGIN is called with SDAG_RTS as the entry point will always be from within an invokeEntry call. These calls end with the corresponding TRACE_EXECUTE_END() from either ck.C:651 or cklocation.C:1981.

Also available in: Atom PDF