Project

General

Profile

Cleanup #292

charmc: Inconsistent handling of distinction between C and C++ linking

Added by Phil Miller almost 6 years ago. Updated over 1 year ago.

Status:
Merged
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
09/10/2013
Due date:
% Done:

0%


Description

Some places in charmc use the variable OPTS_LD, others use OPTS_LDXX, and some even use both! We need to either unify them, or systematically make sure both cases are covered everywhere that's appropriate.

History

#1 Updated by Nikhil Jain almost 6 years ago

  • Assignee set to Nikhil Jain
  • Target version set to 6.6.0

#2 Updated by Phil Miller almost 6 years ago

  • Subject changed from charmc: Inconsistent handling of discintction between C and C++ linking to charmc: Inconsistent handling of distinction between C and C++ linking

Spelling fix

#3 Updated by Nikhil Jain over 5 years ago

  • Target version changed from 6.6.0 to 6.7.0

#4 Updated by Eric Bohm over 4 years ago

  • Assignee changed from Nikhil Jain to Cyril Bordage

#5 Updated by Cyril Bordage over 4 years ago

  • Status changed from New to Implemented

Variables OPTS_LDXX, CMK_CXX_OPTIMIZE and CMK_CXX_PRODUCTION removed.

Need to update documentation for "-ld++" and "-ld++-option".

#6 Updated by Phil Miller about 4 years ago

  • Assignee changed from Cyril Bordage to PPL

#7 Updated by Michael Robson almost 4 years ago

  • Status changed from Implemented to In Progress
  • Target version deleted (6.7.0)
  • Tracker changed from Bug to Cleanup

Per Core discussion

#8 Updated by Sam White over 1 year ago

  • Assignee changed from PPL to Evan Ramos
  • Target version set to 6.9.0

A partial fix, though probably quite rusty at this point: https://charm.cs.illinois.edu/gerrit/#/c/515/

#9 Updated by Evan Ramos over 1 year ago

This issue description is solely about OPTS_LD(XX), while the linked patch also affects CMK_CXX_OPTIMIZE and CMK_CXX_PRODUCTION. Phil's comment on the patch suggests the latter two are out of scope of this issue.

If I updated the patch and also made it only about OPTS_LDXX, would that satisfy this issue?

#10 Updated by Sam White over 1 year ago

Yeah I think so

#11 Updated by Evan Ramos over 1 year ago

  • Status changed from In Progress to Implemented

#12 Updated by Evan Ramos over 1 year ago

  • Status changed from Implemented to Merged

Also available in: Atom PDF