Project

General

Profile

Bug #1978

Segmentation fault in examples/charm++/arraysection and cleanup

Added by Raghavendra Kanakagiri 14 days ago. Updated 8 days ago.

Status:
Merged
Priority:
Normal
Category:
-
Target version:
Start date:
09/11/2018
Due date:
% Done:

0%

Tags:

Description

Segmentation fault when the example in
charm++/arraysection is run.
On a different system setup it runs into an error
contribute: SectionID is not initialized

Also, the example needs to be cleaned up to reflect what is quoted in the manual.
2D section array example needs to be added.

History

#1 Updated by Sam White 14 days ago

Some things to clean up:

1. It doesn't compile on my Mac using GCC:

check.C:35:37: error: use of parameter outside function body before ']' token
  void done(int q, int output[q]){

That line should be:
  void done(int q, int output[]){

2. The CkArgMsg* passed to the Mainchare's constructor is not deleted anywhere.

3. Section creation should use the std::vector-based API rather than the old CkVec one.

4. There are several lines of commented-out code, which should just be removed.

5. The recvMsg() currently calls 'CkFreeMsg(msg);', but I think it's cleaner / more consistent to do 'delete msg;'

#2 Updated by Sam White 13 days ago

  • Status changed from New to In Progress

Cleanup here: https://charm.cs.illinois.edu/gerrit/#/c/charm/+/4566/

Still need a 2D example...

#3 Updated by Sam White 13 days ago

The example builds and runs correctly now for me. Can you try it, and then add a 2D example?

#4 Updated by Raghavendra Kanakagiri 13 days ago

Yes, it works for me. Will add a 2D array example.

#5 Updated by Sam White 13 days ago

  • Status changed from In Progress to Implemented
  • Tags set to sections

#6 Updated by Sam White 8 days ago

  • Status changed from Implemented to Merged

Also available in: Atom PDF