Project

General

Profile

Bug #1970

libmemory- broken without production on BGQ

Added by Sam White 11 months ago. Updated 11 months ago.

Status:
Merged
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
08/25/2018
Due date:
% Done:

0%


Description

The recent changes to how we build the various libmemory objects seems to have broken it.

../bin/charmc   -I. -o libmemory-charmdebug.o -DCMK_MEMORY_BUILD_CHARMDEBUG -optimize -touch-on-failure memory.C
In file included from memory.C:677:
./memory-charmdebug.c:30:2: error: "charmdebug is not enabled (e.g. when building with-production)" 
#error "charmdebug is not enabled (e.g. when building with-production)" 
 ^
memory.C:740:3: error: use of undeclared identifier 'meta_init'
  meta_init(argv);
  ^
memory.C:776:20: error: use of undeclared identifier 'meta_free'; did you mean 'mm_free'?
  MEM_LOCK_AROUND( meta_free(mem); )
                   ^~~~~~~~~
                   mm_free

With production the build completes.

History

#1 Updated by Evan Ramos 11 months ago

This must have been exposed by https://charm.cs.illinois.edu/gerrit/#/c/charm/+/4505/3/src/scripts/Makefile but I don't understand why it's happening. Specifically, it means conv-mach-opt.h became out of sync with conv-mach-opt.sh, or that the Makefile is reading the latter incorrectly. I don't see how the former could ever happen:

AC_ARG_ENABLE([charmdebug],
            [AS_HELP_STRING([--enable-charmdebug],
              [enable charmDebug])], ,
            [enable_charmdebug=yes])

if test "$enable_charmdebug" = "no" 
then
  Echo "CharmDebug is disabled" 
  AC_DEFINE_UNQUOTED(CMK_CHARMDEBUG, 0, [disable charmdebug])
  add_flag CMK_CHARMDEBUG=0
else
  Echo "CharmDebug is enabled" 
  AC_DEFINE_UNQUOTED(CMK_CHARMDEBUG, 1, [enable charmdebug])
  add_flag CMK_CHARMDEBUG=1
fi

For the latter hypothesis, I put together this cleanup: https://charm.cs.illinois.edu/gerrit/4527

#2 Updated by Sam White 11 months ago

  • Status changed from New to Implemented

#3 Updated by Sam White 11 months ago

  • Target version set to 6.9.0

#4 Updated by Evan Ramos 11 months ago

  • Status changed from Implemented to Merged

Also available in: Atom PDF