Project

General

Profile

Cleanup #197

Replace use of signal() with sigaction()

Added by Phil Miller about 6 years ago. Updated over 2 years ago.

Status:
Merged
Priority:
Low
Category:
-
Target version:
Start date:
05/27/2013
Due date:
% Done:

0%


Description

http://glandium.org/blog/?p=2979

Most of our uses of signal() are simply unconditionally setting a signal handler, rather than saving/restoring them. Even then, they're setting handlers other than 'default' or 'ignore', which may be unsafe in multithreaded SMP builds.

Even worse are the few that actually do save and restore handlers. Some of those may even mix poorly with the few sigaction() calls we do have.

Thus, all uses of signal() should be converted to sigaction() as the manual recommends.

History

#1 Updated by Seonmyeong Bak over 3 years ago

  • Assignee set to Seonmyeong Bak

#2 Updated by Sam White almost 3 years ago

  • Status changed from New to In Progress
  • Target version set to 6.8.0

This has been sitting in review since December, please address the comments and get it merged: https://charm.cs.illinois.edu/gerrit/#/c/887/

#3 Updated by Seonmyeong Bak over 2 years ago

  • Status changed from In Progress to Implemented

#4 Updated by Phil Miller over 2 years ago

  • Status changed from Implemented to Merged
  • translation missing: en.field_closed_date set to 2017-02-07 17:10:10.524924

#5 Updated by Jim Phillips over 2 years ago

This broke MPI builds. See bugs #1402 and #1403.

#6 Updated by Jim Phillips over 2 years ago

Also broke all Windows builds. See bug #1403.

Also available in: Atom PDF