Project

General

Profile

Cleanup #1890

Avoid defining VERSION in conv-autoconfig.h to avoid conflicts with applications

Added by Sam White about 1 year ago. Updated about 1 year ago.

Status:
Merged
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
04/26/2018
Due date:
% Done:

0%


Description

When compiling LAMMPS on AMPI I get this:

../read_restart.cpp:51:3: error: expected identifier
  VERSION,SMALLINT,TAGINT,BIGINT,
  ^
/Users/samwhite/Desktop/Sam/Illinois17-18/PPL/charm3/bin/../include/conv-autoconfig.h:1023:17: note: expanded from macro 'VERSION'
#define VERSION "60900" 
                ^
../read_restart.cpp:670:14: error: comparison between pointer and integer ('int' and 'const char *')
    if (flag == VERSION) {
        ~~~~ ^  ~~~~~~~

I've seen similar conflicts in other codes before too. We already have a separate CHARM_VERSION macro, so this one seems redundant.

History

#1 Updated by Sam White about 1 year ago

  • Status changed from New to Implemented

#2 Updated by Sam White about 1 year ago

  • Target version set to 6.9.0
  • Status changed from Implemented to Merged

Also available in: Atom PDF