Project

General

Profile

Bug #1831

Shrink/expand broken by charmrun refactoring

Added by Sam White over 1 year ago. Updated over 1 year ago.

Status:
Merged
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
03/15/2018
Due date:
% Done:

0%


Description

Trying to build with '--enable-shrinkexpand' fails on compiling charmrun with the following on netlrts-darwin-x86_64:

../../bin/charmc -g -O0  -Wno-error -lm -I.. -L../libs -c -seq -DCMK_NOT_USE_CONVERSE=1 charmrun.C -o charmrun.o
charmrun.C:4300:23: error: use of undeclared identifier 'nodetab_size'
  for (int i = 0; i < nodetab_size; i++)
                      ^
charmrun.C:4301:38: error: use of undeclared identifier 'nodetab_table'; did you mean 'host_table'?
    sprintf(dest1, "%s %s", dest1, (*nodetab_table[i]).name);
                                     ^~~~~~~~~~~~~
                                     host_table
charmrun.C:1352:36: note: 'host_table' declared here
static std::vector<nodetab_host *> host_table;

History

#1 Updated by Evan Ramos over 1 year ago

  • Status changed from New to In Progress

https://charm.cs.illinois.edu/gerrit/3860

Are there any tests for shrink/expand?

#2 Updated by Sam White over 1 year ago

examples/charm++/shrink_expand. It doesn't look like it's part of automated testing

#3 Updated by Evan Ramos over 1 year ago

The example crashes. I will have to debug this.

#4 Updated by Sam White over 1 year ago

k, since it doesn't have automated testing it may have been broken for a while now. Though I believe we tested it for v6.8.0's release.

#5 Updated by Evan Ramos over 1 year ago

  • Status changed from In Progress to Implemented

Fixed in: https://charm.cs.illinois.edu/gerrit/3900

Tested with netlrts-darwin-x86_64 and netlrts-linux-x86_64.

#6 Updated by Sam White over 1 year ago

  • Status changed from Implemented to Merged

Also available in: Atom PDF