Project

General

Profile

Bug #1791

ddt dependence missing in AMPI's makefile

Added by Sam White over 1 year ago. Updated over 1 year ago.

Status:
Merged
Priority:
Normal
Category:
AMPI
Target version:
Start date:
02/01/2018
Due date:
% Done:

0%


Description

ddt was moved into AMPI, but there is no dependence on ddt or its header, so if you update DDT and re-make AMPI the build system ignores your changes: https://charm.cs.illinois.edu/gerrit/#/c/3468/

History

#1 Updated by Matthias Diener over 1 year ago

This seems to work for me:

$ cd charm/tmp/libs/ck-libs/ampi
$ make
AMPI built successfully
AMPIF built successfully
$ touch ddt.C
$ make
/Users/mdiener/Work/charm/bin/charmc  -c ampi.C
/Users/mdiener/Work/charm/bin/charmc  -c ampif.C
[...]

Same for ddt.h.

ddt.o and ddt.h should be dependencies through the HEADDEP and OBJS Makefile variables.

#2 Updated by Matthias Diener over 1 year ago

... except that ddt.o does not get rebuilt when ddt.h changes.
Patch here: https://charm.cs.illinois.edu/gerrit/#/c/3609/

#3 Updated by Matthias Diener over 1 year ago

  • Status changed from New to Merged

Also available in: Atom PDF