Project

General

Profile

Feature #1731

Complete spack installation script

Added by Sam White 9 months ago. Updated about 2 months ago.

Status:
Merged
Priority:
Normal
Category:
-
Target version:
Start date:
10/31/2017
Due date:
% Done:

0%


Description

Spack has a charm package, but it is out of date (v6.7.1) and only supports a few charm build options (net, netlrts, mpi, verbs).

Add pamilrts-{bluegeneq, linux-x86_64ppcle}, verbs-linux-ppc64le, ofi-, gni-crayx{e,c}. Remove deprecated 'net-' builds. Add different compiler options. Add AMPI and LIBS build targets. Add 6.7.0, 6.8.0, 6.8.1, 6.8.2 releases.

https://github.com/LLNL/spack/tree/develop/var/spack/repos/builtin/packages/charm

History

#1 Updated by Sam White 8 months ago

Note the mpi.patch file they have in the spack/charm package is no longer needed since 6.8.0

#2 Updated by Sam White 6 months ago

  • Assignee set to Karthik Senthil

#3 Updated by Sam White 6 months ago

  • Assignee deleted (Karthik Senthil)

This wis now assigned to a Charmworks intern

#5 Updated by Sam White 5 months ago

  • Status changed from New to In Progress

#6 Updated by Matthias Diener 5 months ago

We should discuss if it makes sense to put the package in charm++'s repository, or if we just update the package on spack's GitHub.

#7 Updated by Sam White 4 months ago

Spack pull request here: https://github.com/spack/spack/pull/7291

I'm not sure if Edward Kim is still working for Charmworks on this, so we may need someone else to take it over and address the feedback from Spack developers.

#8 Updated by Matthias Diener 4 months ago

@Sam, do you know what the status is? I'd be happy to take this over, but I don't have permissions to modify the pull request.

#9 Updated by Sam White 4 months ago

I just asked Edward and he just hadn't seen the comments on the pull request for whatever reason. So he'll keep working on it

#10 Updated by Sam White about 2 months ago

  • Status changed from In Progress to Merged
  • Target version set to 6.9.0

Edward Kim got his pull request merged into the Spack repo: https://github.com/spack/spack/pull/7291

#11 Updated by Matthias Diener about 2 months ago

It would be nice to be able to build the git version of charm++ via spack (which is something spack supports: https://spack.readthedocs.io/en/latest/packaging_guide.html#git ). In that case, we would need to depend on automake and autoconf as well.

#12 Updated by Sam White about 2 months ago

Yeah that'd be useful, can you do that? Edward Kim is I think no longer at Charmworks.

#13 Updated by Matthias Diener about 2 months ago

  • Assignee set to Matthias Diener
  • Status changed from Merged to In Progress

Ok, I'll do it.

#15 Updated by Matthias Diener about 2 months ago

  • Status changed from In Progress to Implemented

#16 Updated by Matthias Diener about 2 months ago

  • Status changed from Implemented to Merged

The patch has been merged upstream.

#17 Updated by Matthias Diener about 2 months ago

By the way, should this be mentioned somewhere in the manual (e.g., Appendix A. Installing Charm++)?

#18 Updated by Sam White about 2 months ago

Yeah it could be

#19 Updated by Matthias Diener about 2 months ago

Patch for the manual is here: https://charm.cs.illinois.edu/gerrit/4229

Also available in: Atom PDF