Project

General

Profile

Bug #1669

Add machine layer files as Makefile dependencies for building the machine layer library

Added by Nitin Bhat 6 months ago. Updated 2 months ago.

Status:
Merged
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
08/31/2017
Due date:
% Done:

0%


Description

There are no existing Makefile dependencies for the pamilrts layer. Similarly, the gni layer doesn't have a few dependencies like machine-onesided.c and machine-onesided.h. Additionally, it should be ensured that all include files used in machine-common-core.c should be also added as dependencies. Atleast for all lrts layers, it'll be good to do a check that all makefile dependencies are added.

History

#1 Updated by Phil Miller 5 months ago

Could this be addressed by running something equivalent to the current make depends and putting the output directly in Makefile.machine or in a Make.depends.machine file that we can include?

#2 Updated by Eric Bohm 5 months ago

  • Assignee set to Phil Miller

#3 Updated by Phil Miller 3 months ago

  • Target version set to 6.9.0
  • Status changed from New to Implemented

Teach make to automate this:
https://charm.cs.illinois.edu/gerrit/3400

#4 Updated by Phil Miller 2 months ago

  • Status changed from Implemented to Merged

Follow-up fix for Windows builds here: https://charm.cs.illinois.edu/gerrit/3442

Incidentally, this would (I think) let us move away from a pre-generated, committed Make.depends, and just have it all happen at build time automatically.

Also available in: Atom PDF