Project

General

Profile

Bug #1610

Fix broken builds due to minor errors in examples/rdma/simpleRdma

Added by Nitin Bhat about 2 years ago. Updated about 2 years ago.

Status:
Merged
Priority:
High
Assignee:
Category:
-
Target version:
-
Start date:
06/15/2017
Due date:
% Done:

100%

Tags:

Description

After merging the SDAG change related to RDMA (https://charm.cs.illinois.edu/gerrit/#/c/2572/), the nightly build ran the rdma examples (as previously, the makefile wasn't updated and the rdma examples were never run). During the first test of rdma examples on all the builds, targets related to bigsim and windows broke because of different reasons. (http://charm.cs.illinois.edu/autobuild/old.2017_06_15__01_00/)

Bigsim build (netlrts-linux-x86_64-bigsim) broke because of an incorrect makefile. Fix: Remove rdma examples from bigsim tests.

Windows builds broke because of a call to the time function from the simpleRdma example. Fix: Remove the time call (and even the srand call where time() is passed).

History

#1 Updated by Nitin Bhat about 2 years ago

  • Priority changed from Normal to High
  • Assignee set to Nitin Bhat
  • Subject changed from Fix broken builds due to minor errors in simpleRdma to Fix broken builds due to minor errors in examples/rdma/simpleRdma

#2 Updated by Nitin Bhat about 2 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Implemented

#3 Updated by Sam White about 2 years ago

  • Status changed from Implemented to Merged

Also available in: Atom PDF