Project

General

Profile

Bug #1547

Deprecate the FFT library in ck-libs in favor of Nikhil's new FFT library

Added by Eric Mikida about 2 years ago. Updated over 1 year ago.

Status:
Merged
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
05/02/2017
Due date:
% Done:

50%

Estimated time:
24.00 h

Description

Right now the libraries manual still points to the in-tree version of the FFT library. Anyone using this library should get a deprecation warning, and the manual should be updated to point to Nikhil's library at https://charm.cs.illinois.edu/gerrit/gitweb?p=libs%2Ffft.git;a=summary instead.

History

#1 Updated by Eric Bohm about 2 years ago

  • Assignee changed from PPL to Eric Bohm

#2 Updated by Eric Bohm about 2 years ago

  • Status changed from New to In Progress
  • Estimated time set to 24.00 h
  • % Done changed from 0 to 10

There are a few complications to accomplishing this in that Nikhil's fft library is not a drop in replacement for the prior version.

  1. Documentation is far from complete
    1. the current manual includes inline TODO items from a prior review
    2. the API is not completely described
    3. there is no functioning example in the manual
  2. the tests provided do not run correctly
    1. they either crash or hang
  3. the prior library provided both a Charm and AMPI API.
    1. no documentation is provided for using this library with AMPI
  4. this library is thought to be interoperable with MPI from publication history, but no documentation is provided.
  5. it is known to work in production for OpenAtom, but we lack production tests for any part of the API not in use by OpenAtom.

Might be a good summer project, but current state appear to be days (possibly more depending on how much functionality is necessary) of effort away from production level.

#3 Updated by Eric Bohm about 2 years ago

  • Target version changed from 6.8.0 to 6.8.1

#4 Updated by Phil Miller about 2 years ago

  • Description updated (diff)

#5 Updated by Phil Miller about 2 years ago

  • Assignee changed from Eric Bohm to Justin Szaday

#6 Updated by Justin Szaday almost 2 years ago

Just a few questions about the way forward.
  1. The prior library's documentation notes that the AMPI API was 'not in CVS,' was it ever actually released?
  2. Should I try to address the TODO's in the documentation? If so, I would like to have a discussion with the relevant people so I can get a better idea of what the goal of some of these todo's originally was (mostly due to my lack of familiarity with this library).
  3. "Thought to be interoperable with MPI," does this just mean we need to verify it can be run in interopt mode or is more thorough testing required?

#7 Updated by Eric Bohm almost 2 years ago

  • Target version changed from 6.8.1 to 6.9.0

#8 Updated by Eric Bohm almost 2 years ago

  • Assignee changed from Justin Szaday to Dong Hun Lee

#9 Updated by Dong Hun Lee over 1 year ago

  • % Done changed from 10 to 50

https://charm.cs.illinois.edu/gerrit/#/c/3421/

New manual is largely based on the within library manual.

#10 Updated by Dong Hun Lee over 1 year ago

  • Status changed from In Progress to Implemented

#11 Updated by Sam White over 1 year ago

  • Status changed from Implemented to Merged

Also available in: Atom PDF