Project

General

Profile

Bug #1542

CkArrayCreated callback should be part of CkArrayOptions

Added by Sam White about 2 years ago. Updated 11 months ago.

Status:
New
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
04/28/2017
Due date:
% Done:

0%


Description

The asynchronous array creation API added an optional parameter after CkArrayOptions to ckNew(). I think this callback should be a part of CkArrayOptions rather than an optional argument. It looks like that API addition was made before 6.7.0 though, so it would be a breaking change... Thoughts?

Initial asynchronous array creation API patch: https://charm.cs.illinois.edu/gerrit/#/c/736/

History

#1 Updated by Phil Miller about 2 years ago

Design-wise, I agree with you, it probably should be (have been) part of CkArrayOptions.

We can add the new version of the API, and just map the existing implementation to setting the callback in the CkArrayOptions and passing it to the revised version.

#2 Updated by Sam White about 2 years ago

We may want to get any API change here into 6.8.0. We need to decide on the relationship between the new initCallback and the existing asynchronous array creation API though

#3 Updated by Sam White about 2 years ago

Core discussion is needed here

#4 Updated by Eric Bohm about 2 years ago

  • Assignee set to Eric Mikida

#5 Updated by Sam White over 1 year ago

If we are going to make a breaking API change here, 6.9.0 is the time to do it

#6 Updated by Sam White 11 months ago

  • Assignee changed from Eric Mikida to Evan Ramos

#7 Updated by Evan Ramos 11 months ago

Phil Miller wrote:

We can add the new version of the API, and just map the existing implementation to setting the callback in the CkArrayOptions and passing it to the revised version.

I agree with this.

Also available in: Atom PDF