Project

General

Profile

Bug #1441

Lies at startup about "The comm. thread both sends and receives messages"

Added by Jim Phillips 9 months ago. Updated about 2 months ago.

Status:
Merged
Priority:
Urgent
Assignee:
Category:
Machine Layers
Target version:
Start date:
02/21/2017
Due date:
% Done:

0%


Description

There is logic for setting and reporting Cmi_smp_mode_setting at startup, but this only reflects the behavior of the mpi-smp and gni-smp layers.

jim@sunnyvale$grep -r Cmi_smp_mode_setting .
./arch/util/machine-common-core.c:static enum MACHINE_SMP_MODE Cmi_smp_mode_setting = COMM_THREAD_SEND_RECV;
./arch/util/machine-common-core.c:      if (Cmi_smp_mode_setting == COMM_THREAD_SEND_RECV) {
./arch/util/machine-common-core.c:      } else if (Cmi_smp_mode_setting == COMM_THREAD_ONLY_RECV) {
./arch/util/machine-common-core.c:      } else if (Cmi_smp_mode_setting == COMM_WORK_THREADS_SEND_RECV) {
./arch/util/machine-common-core.c:      } else if (Cmi_smp_mode_setting == COMM_THREAD_NOT_EXIST) {
./arch/util/machine-common-core.c:    if(Cmi_smp_mode_setting == COMM_THREAD_ONLY_RECV
./arch/util/machine-common-core.c:       || Cmi_smp_mode_setting == COMM_THREAD_NOT_EXIST)
./arch/mpi/machine.c:    if (Cmi_smp_mode_setting == COMM_THREAD_SEND_RECV) {
./arch/mpi/machine.c:  if (Cmi_smp_mode_setting == COMM_THREAD_ONLY_RECV) {
./arch/mpi/machine.c:    if(Cmi_smp_mode_setting == COMM_THREAD_SEND_RECV){
./arch/mpi/machine.c:    }else if(Cmi_smp_mode_setting == COMM_THREAD_ONLY_RECV) {
./arch/mpi/machine.c:      Cmi_smp_mode_setting = COMM_THREAD_ONLY_RECV;
./arch/mpi/machine.c:    if (Cmi_smp_mode_setting == COMM_THREAD_SEND_RECV)
./arch/mpi/machine.c:    if (Cmi_smp_mode_setting == COMM_THREAD_ONLY_RECV && _thread_provided != MPI_THREAD_MULTIPLE) {
./arch/mpi/machine.c:        Cmi_smp_mode_setting = COMM_THREAD_SEND_RECV; 
./arch/gni/machine.c:    Cmi_smp_mode_setting = COMM_WORK_THREADS_SEND_RECV;

Related issues

Related to Charm++ - Bug #1518: net-linux-x86_64-ibverbs-smp-iccstatic build failure in machine-ibverbs.c Merged 04/19/2017

History

#1 Updated by Jim Phillips 9 months ago

More specifically, verbs and net-ibverbs only use the comm thread for receives.

#2 Updated by Sam White 9 months ago

  • Target version set to 6.8.0
  • Assignee set to Nitin Bhat

#3 Updated by Phil Miller 8 months ago

  • Assignee changed from Nitin Bhat to Jaemin Choi

#4 Updated by Phil Miller 8 months ago

  • Priority changed from Normal to Urgent

Setting priority higher because these are easy to fix things that act as paper-cuts to users

#5 Updated by Jaemin Choi 8 months ago

  • Status changed from New to Implemented

#6 Updated by Sam White 7 months ago

  • Status changed from Implemented to Merged
  • Subject changed from lies at startup about "The comm. thread both sends and receives messages" to Lies at startup about "The comm. thread both sends and receives messages"

#7 Updated by Nitin Bhat 3 months ago

  • Target version changed from 6.8.0 to 6.8.1
  • Status changed from Merged to New

A pamilrts-smp build, which doesn't use a comm thread, also displays this message "The comm. thread both sends and receives messages". Additionally, it'll be good to do a rundown of smp builds for all machine layers and test if the comm thread mode is displayed correctly.

#8 Updated by Phil Miller 2 months ago

Nitin, could you follow up with checks on the other layers and note whether/what needs to be done here?

#9 Updated by Nitin Bhat about 2 months ago

Sure. I'll do that.

#10 Updated by Nitin Bhat about 2 months ago

  • Assignee changed from Jaemin Choi to Nitin Bhat

#11 Updated by Phil Miller about 2 months ago

  • Related to Bug #1518: net-linux-x86_64-ibverbs-smp-iccstatic build failure in machine-ibverbs.c added

#12 Updated by Nitin Bhat about 2 months ago

  • Status changed from New to Implemented

Did a rundown of the LRTS layers to confirm that the displayed message is correct. The default mode is COMM_THREAD_SEND_RECV. gni, netlrts, mpi, ofi and pamilrts async mode all use the default mode. verbs is set to COMM_THREAD_ONLY_RECV and pamilrts smp mode (not async) is set to COMM_THREAD_NOT_EXIST.

Fix for verbs: https://charm.cs.illinois.edu/gerrit/#/c/2360/
Fix for pamilrts: https://charm.cs.illinois.edu/gerrit/#/c/3081/

#13 Updated by Phil Miller about 2 months ago

  • Status changed from Implemented to Merged

Also available in: Atom PDF