Project

General

Profile

Cleanup #1418

Remove commlibInfo from _CkSectionInfoStruct

Added by Sam White over 2 years ago. Updated over 2 years ago.

Status:
Merged
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
02/14/2017
Due date:
% Done:

0%


Description

Commlib has been removed from Charm for a while now right? Remove this leftover data structure. While at it, I don't see any need for separate _CkSectionInfoStruct and CkSectionInfo classes.

   union section_type {
        // Used when section is delegated to CkMulticast
        struct sec_mcast {
            /// Counter tracking the last reduction that has traversed this section
            int redNo;
            // Pointer to mCastCookie
            void *val;
        }
        sCookie;

        // Used when section is delegated to Comlib
        struct commlibInfo{
            // The instance of the comm. lib.
            short  instId;
            // This field indicates local array indices to multicast to:
            // (Deprecated) COMLIB_MULTICAST_ALL for all local elements, 
            // COMLIB_MULTICAST_NEW_SECTION, elements are attached 
            // to this message
            // COMLIB_MULTICAST_OLD_SECTION use previously created section
            // COMLIB_MULTICAST_SECTION_ERROR mark the section as old
            short status;
            // Used to compare section ID's
            int id;
        }
        cInfo;
    } sInfo;

History

#1 Updated by Juan Galvez over 2 years ago

  • Assignee set to Juan Galvez

Taking over this since it looks like I'm going to make changes to CkSectionInfo anyway.

#2 Updated by Juan Galvez over 2 years ago

  • Status changed from New to Implemented

#3 Updated by Phil Miller over 2 years ago

  • Status changed from Implemented to Merged

Also available in: Atom PDF