Project

General

Profile

Feature #1417

Reduce CkReductionMsg envelope size

Added by Sam White over 2 years ago. Updated over 1 year ago.

Status:
Merged
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
02/14/2017
Due date:
% Done:

0%


Description

CkReductionMsg has accumulated fields that are often unused. Here are its fields that are unconditionally compiled:

     int dataSize; //Length of array below, in bytes
     void *data; //Reduction data
     CMK_REFNUM_TYPE userFlag; //Some sort of identifying flag, for client use
     CkCallback callback; //What to do when done
     CkCallback secondaryCallback; // the group callback is piggybacked on the nodegrp reduction
     bool migratableContributor; // are the contributors migratable

     int sourceFlag;
     int fromPE;

     CkReduction::reducerType reducer;
     int redNo; //The serial number of this reduction
     int gcount; //Contribution to the global contributor count

     // for section multicast/reduction library
     CkSectionInfo sid;   // section cookie for multicast
     char rebuilt;          // indicate if the multicast tree needs rebuilt
     int nFrags;
     int fragNo;      // fragment of a reduction msg (when pipelined)

     double dataStorage; //Start of data array (so it's double-aligned)
     int no;

Some initial observations:
  • 'secondaryCallback' is already being removed here: https://charm.cs.illinois.edu/gerrit/#/c/2216/
  • 'no' is completely unused, as far as I can tell.
  • 'dataStorage' exists only for alignment purposes. Is there another way to get the alignment without always adding 8 bytes?
  • The CkSectionInfo is itself 32 bytes, add the other 3 fields for sections and you get 39 bytes in every CkReductionMsg that are only used if that message is for a section.

History

#1 Updated by Sam White over 2 years ago

Remove unused member variable 'no': https://charm.cs.illinois.edu/gerrit/#/c/2244/

#2 Updated by Sam White over 2 years ago

  • Assignee set to Eric Mikida
  • Target version set to 6.8.0

#3 Updated by Sam White over 2 years ago

  • Target version changed from 6.8.0 to 6.9.0

#4 Updated by Sam White about 2 years ago

We could potentially have a boolean field for if the CkReductionMsg is for a section and only allocate the space for the section stuff if it is needed? Adding Juan as a watcher...

#5 Updated by Eric Mikida almost 2 years ago

  • Target version deleted (6.9.0)

#6 Updated by Sam White over 1 year ago

This commit reduces the size of CkReductionMsg's from 168 to 136 Bytes and the size of CkCallback's from 72 to 64 Bytes: https://charm.cs.illinois.edu/gerrit/#/c/3866/

This reduces the size of Charm's message envelope from 80 Bytes to 64 Bytes: https://charm.cs.illinois.edu/gerrit/#/c/charm/+/3872/

You can see the size and packing of objects via "clang -cc1 -fdump-record-layouts". The bulk of CkReductionMsg's size is still due to Section support, both in CkReduction's section-related members and in the CkCallback, which is itself bloated by Section support. But I think we can safely mark this 'done' for now.

#7 Updated by Sam White over 1 year ago

  • Target version set to 6.9.0
  • Assignee changed from Eric Mikida to Sam White
  • Status changed from New to Merged

Also available in: Atom PDF