charm.git
11 years agoAdding ChunkMulticast strategy. The strategy is designed for bandwidth bound multicasts,
Edgar Solomonik [Wed, 6 Jan 2010 20:36:52 +0000 (14:36 -0600)]
Adding ChunkMulticast strategy. The strategy is designed for bandwidth bound multicasts,
and subdivides the message into pieces then routes the pieces in a few different ways.

The strategy isn't used anywhere yet so it should not break anything. Nevertheless,
it should be functional.

Also checking in updated Makefile and updated Make.depends. The Make.depends was
created by doing a net-linux-x86_64 build then doing make depends.

11 years agofixed for bigsim build (CmiNumPes() should not be used to get number of processors)
Gengbin Zheng [Tue, 5 Jan 2010 06:48:15 +0000 (00:48 -0600)]
fixed for bigsim build (CmiNumPes() should not be used to get number of processors)

11 years agoFixing bug when previous phase isn't available at startup
Isaac Dooley [Tue, 22 Dec 2009 22:02:22 +0000 (16:02 -0600)]
Fixing bug when previous phase isn't available at startup

11 years agoDeveloping a steering scheme for control points
Isaac Dooley [Tue, 22 Dec 2009 21:44:23 +0000 (15:44 -0600)]
Developing a steering scheme for control points

11 years agoSimplifying the control point effects script, and exposing the effect information.
Isaac Dooley [Tue, 22 Dec 2009 21:23:22 +0000 (15:23 -0600)]
Simplifying the control point effects script, and exposing the effect information.

11 years agoAdding more performance steering functionality
Isaac Dooley [Tue, 22 Dec 2009 20:47:01 +0000 (14:47 -0600)]
Adding more performance steering functionality

11 years agoFixing the collecting and recording of idle time measurments for each phase.
Isaac Dooley [Tue, 22 Dec 2009 20:12:13 +0000 (15:12 -0500)]
Fixing the collecting and recording of idle time measurments for each phase.

11 years agoMerge branch 'charm' of charmgit:charm into charm
Isaac Dooley [Mon, 21 Dec 2009 19:24:26 +0000 (14:24 -0500)]
Merge branch 'charm' of charmgit:charm into charm

Conflicts:
src/ck-cp/controlPoints.C

11 years agoCleaning up shutdown code of control point module to allow various things to complete...
Isaac Dooley [Mon, 21 Dec 2009 19:17:49 +0000 (13:17 -0600)]
Cleaning up shutdown code of control point module to allow various things to complete before calling CkExit.

11 years agoReenabling the idle time gathering code at the end of each phase.
Isaac Dooley [Mon, 21 Dec 2009 18:54:55 +0000 (13:54 -0500)]
Reenabling the idle time gathering code at the end of each phase.

11 years agoMerge branch 'charm' of charmgit:charm into charm
Phil Miller [Mon, 21 Dec 2009 18:14:35 +0000 (12:14 -0600)]
Merge branch 'charm' of charmgit:charm into charm

11 years agoclean up the code that automatically generates pup fortran interface using a better...
Gengbin Zheng [Mon, 21 Dec 2009 18:08:39 +0000 (12:08 -0600)]
clean up the code that automatically generates pup fortran interface using a better written loop, and covers more data types.

11 years agoupdated from running script
Gengbin Zheng [Mon, 21 Dec 2009 07:02:55 +0000 (01:02 -0600)]
updated from running script

11 years agomodified script to automatically generate pup_f.f90 with pups for multi-dimensional...
Gengbin Zheng [Mon, 21 Dec 2009 07:01:49 +0000 (01:01 -0600)]
modified script to automatically generate pup_f.f90 with pups for multi-dimensional array types, and the interface blocks for function overloading.

11 years agoadded fpup_long/fpup_longs, also added a hidden f90 subrotuine (ending with "g")...
Gengbin Zheng [Mon, 21 Dec 2009 06:34:07 +0000 (00:34 -0600)]
added fpup_long/fpup_longs, also added a hidden f90 subrotuine (ending with "g") to be callable from f90 interface module (pup_f.f90)

11 years agolink -lconv-utilf when linking ampi in fortran mode to include functions for pup...
Gengbin Zheng [Mon, 21 Dec 2009 06:33:21 +0000 (00:33 -0600)]
link -lconv-utilf when linking ampi in fortran mode to include functions for pup fortran.

11 years agoprint PE number in stack backtrace
Gengbin Zheng [Mon, 21 Dec 2009 06:32:30 +0000 (00:32 -0600)]
print PE number in stack backtrace

11 years agoadd fortran interface to cmimemorycheck
Gengbin Zheng [Mon, 21 Dec 2009 06:31:29 +0000 (00:31 -0600)]
add fortran interface to cmimemorycheck

11 years agoMerge branch 'charm' of charmgit:charm into charm
Gengbin Zheng [Mon, 21 Dec 2009 06:30:39 +0000 (00:30 -0600)]
Merge branch 'charm' of charmgit:charm into charm

11 years agoTests: Remove some debug prints in SDAG migration test
Phil Miller [Sun, 20 Dec 2009 20:12:45 +0000 (14:12 -0600)]
Tests: Remove some debug prints in SDAG migration test

11 years agospanning trees: code comments with tips on how to add new construction strategies
Ramprasad Venkataraman [Fri, 18 Dec 2009 23:33:11 +0000 (17:33 -0600)]
spanning trees: code comments with tips on how to add new construction strategies

11 years agoMerge branch 'charm' of charmgit:charm into charm
Isaac Dooley [Fri, 18 Dec 2009 21:10:05 +0000 (15:10 -0600)]
Merge branch 'charm' of charmgit:charm into charm

11 years agoAdding command line arguments to enable gathering of utilization & Memory usage measu...
Isaac Dooley [Fri, 18 Dec 2009 21:05:47 +0000 (15:05 -0600)]
Adding command line arguments to enable gathering of utilization & Memory usage measurements in control point framework.

11 years agoSome comments for callback constructors
Ramprasad Venkataraman [Thu, 17 Dec 2009 19:37:08 +0000 (13:37 -0600)]
Some comments for callback constructors

11 years agominor change in xi-symbol.h preprocess() prototype to get rid of compiler warnings...
Gengbin Zheng [Wed, 16 Dec 2009 18:00:45 +0000 (12:00 -0600)]
minor change in xi-symbol.h preprocess() prototype to get rid of compiler warnings with icpc.

11 years agoMerge branch 'charm' of charmgit:charm into charm
Gengbin Zheng [Wed, 16 Dec 2009 17:11:45 +0000 (11:11 -0600)]
Merge branch 'charm' of charmgit:charm into charm

11 years agosome fixes for -pedantic
Gengbin Zheng [Wed, 16 Dec 2009 17:11:07 +0000 (11:11 -0600)]
some fixes for -pedantic

11 years agoPedantry: no ';' after PUPbytes(foo) or function definitions
Phil Miller [Wed, 16 Dec 2009 17:03:31 +0000 (11:03 -0600)]
Pedantry: no ';' after PUPbytes(foo) or function definitions

11 years agoCorrecting the bad mistake of blowing away some of Isaac's and Chao's changes
Chee Wai Lee [Tue, 15 Dec 2009 20:54:25 +0000 (14:54 -0600)]
Correcting the bad mistake of blowing away some of Isaac's and Chao's changes
with the last checkin.

11 years agofixed compiler errors in operator "+"
Gengbin Zheng [Tue, 15 Dec 2009 17:36:11 +0000 (11:36 -0600)]
fixed compiler errors in operator "+"

11 years agoImplementation of recovery for the team-based message-logging approach.
Esteban Meneses [Mon, 14 Dec 2009 15:49:26 +0000 (09:49 -0600)]
Implementation of recovery for the team-based message-logging approach.

11 years agoPreliminary modifications for API (only) compatibility with ARMCI 1.4 (2008).
Chee Wai Lee [Sat, 12 Dec 2009 23:44:16 +0000 (17:44 -0600)]
Preliminary modifications for API (only) compatibility with ARMCI 1.4 (2008).

11 years agoMerge branch 'charm' of charmgit:charm into charm
Gengbin Zheng [Fri, 11 Dec 2009 22:20:30 +0000 (16:20 -0600)]
Merge branch 'charm' of charmgit:charm into charm

11 years agoadded static to all local variables to prevent these varaibles be treated by swapglob...
Gengbin Zheng [Fri, 11 Dec 2009 22:18:56 +0000 (16:18 -0600)]
added static to all local variables to prevent these varaibles be treated by swapglobals. This makes paranoid works with swapglobals.

11 years agoMerge branch 'msa-import' into charm
Phil Miller [Fri, 11 Dec 2009 18:13:08 +0000 (12:13 -0600)]
Merge branch 'msa-import' into charm

11 years agoMSA Mat-mul Example: Make the tests whine, not fail
Phil Miller [Fri, 11 Dec 2009 18:10:50 +0000 (12:10 -0600)]
MSA Mat-mul Example: Make the tests whine, not fail

11 years agoMerge branch 'charm' of charmgit:charm into charm
Gengbin Zheng [Fri, 11 Dec 2009 09:17:05 +0000 (03:17 -0600)]
Merge branch 'charm' of charmgit:charm into charm

11 years agochanged infiCmiChunkPools to static, to avoid swapglobal privatizing it.
Gengbin Zheng [Fri, 11 Dec 2009 09:16:18 +0000 (03:16 -0600)]
changed infiCmiChunkPools to static, to avoid swapglobal privatizing it.

11 years agoFix side test to compile
Phil Miller [Mon, 16 Nov 2009 22:21:18 +0000 (16:21 -0600)]
Fix side test to compile

11 years agoParFUM: Comment cleanup in parallel_part.C
Phil Miller [Mon, 14 Sep 2009 18:22:14 +0000 (13:22 -0500)]
ParFUM: Comment cleanup in parallel_part.C

11 years agofixed access mode violations in msa partitioning code
Aaron Becker [Mon, 14 Sep 2009 18:07:09 +0000 (13:07 -0500)]
fixed access mode violations in msa partitioning code

The old parallel partitioner pulls references out of the MSA array and
uses them without regard to access restrictions in accumulate mode. This
replaces those uses with invocations of += on custom types.

11 years agomoved += definition to .C file to prevent duplicate symbols
Aaron Becker [Mon, 14 Sep 2009 18:06:17 +0000 (13:06 -0500)]
moved += definition to .C file to prevent duplicate symbols

11 years agoMSA & ParFUM: Pass templating of MSA type args through
Phil Miller [Mon, 14 Sep 2009 17:41:01 +0000 (12:41 -0500)]
MSA & ParFUM: Pass templating of MSA type args through

11 years agoMSA Add templated operator += and template DefaultEntry::accumulate
Phil Miller [Mon, 14 Sep 2009 17:36:58 +0000 (12:36 -0500)]
MSA Add templated operator += and template DefaultEntry::accumulate

11 years agoMSA Example: Make 'matmul' compile with new API
Phil Miller [Thu, 10 Sep 2009 23:08:08 +0000 (18:08 -0500)]
MSA Example: Make 'matmul' compile with new API

The MSA API changed. Change the matrix multiplication
benchmark/example with all of its variations to match.

11 years agoMSA: Add fuller range of functionality to 2D's handles
Phil Miller [Thu, 10 Sep 2009 19:14:22 +0000 (14:14 -0500)]
MSA: Add fuller range of functionality to 2D's handles

The handles for the 2D code were missing some operations and forms,
particularly the two-index forms that don't require the caller to do
the index translation. Fix that.

11 years agoParFUM: Make MsaHashtable compile against the revised MSA
Phil Miller [Thu, 10 Sep 2009 16:30:47 +0000 (11:30 -0500)]
ParFUM: Make MsaHashtable compile against the revised MSA

MSA was revised to return a more strictly-checked object when
accumulating into the array. However, it now passes through overloaded
operator+= on ENTRY objects, to ease some pain of not accumulating the
same type. Define an operator+= appropriate for MsaHashtable, and use
it in place of the older direct access that violated MSA's strict
semantics.

11 years agoMSA Example: bring up to date with modern MSA API
Phil Miller [Thu, 10 Sep 2009 01:56:31 +0000 (20:56 -0500)]
MSA Example: bring up to date with modern MSA API

11 years agoMSA: Add missing accumulate-mode handle to 2D MSa definition
Phil Miller [Wed, 9 Sep 2009 17:05:03 +0000 (12:05 -0500)]
MSA: Add missing accumulate-mode handle to 2D MSa definition

11 years agoMSA Example: Make a dead-simple transpose test compile and run again
Phil Miller [Tue, 8 Sep 2009 22:06:09 +0000 (17:06 -0500)]
MSA Example: Make a dead-simple transpose test compile and run again

11 years agoParFUM: Adapt to the MSA changes that don't require an instance of ENTRY_OPS
Phil Miller [Tue, 8 Sep 2009 21:13:59 +0000 (16:13 -0500)]
ParFUM: Adapt to the MSA changes that don't require an instance of ENTRY_OPS

11 years agoMSA: Use CkIndex properly
Phil Miller [Sun, 6 Sep 2009 21:59:53 +0000 (16:59 -0500)]
MSA: Use CkIndex properly

11 years agoMake Writable<T>::operator= return its RHS, as required
Phil Miller [Tue, 21 Jul 2009 01:55:47 +0000 (20:55 -0500)]
Make Writable<T>::operator= return its RHS, as required

11 years agoMSA: De-uglify MSA3D::Handle::pup()
Phil Miller [Fri, 17 Jul 2009 07:30:26 +0000 (02:30 -0500)]
MSA: De-uglify MSA3D::Handle::pup()

11 years agoMSA: Set PageArray's synchronization reduction client at contribute time
Phil Miller [Fri, 17 Jul 2009 07:28:35 +0000 (02:28 -0500)]
MSA: Set PageArray's synchronization reduction client at contribute time

11 years agoMSA: Interface overhaul
Phil Miller [Thu, 16 Jul 2009 01:16:22 +0000 (20:16 -0500)]
MSA: Interface overhaul

11 years agoMSA: Assert that a page from the pool is an actual allocation
Phil Miller [Thu, 16 Jul 2009 01:14:57 +0000 (20:14 -0500)]
MSA: Assert that a page from the pool is an actual allocation

11 years agoMSA: Remove dead code
Phil Miller [Thu, 16 Jul 2009 01:13:55 +0000 (20:13 -0500)]
MSA: Remove dead code

11 years agoMSA: Always write identity to newly allocated pages
Phil Miller [Thu, 16 Jul 2009 01:08:25 +0000 (20:08 -0500)]
MSA: Always write identity to newly allocated pages

11 years agoMSA: Simplify 3D buffered accumulation code
Phil Miller [Tue, 14 Jul 2009 20:31:36 +0000 (15:31 -0500)]
MSA: Simplify 3D buffered accumulation code

11 years agoMSA: Fix some 3D Accumulation errors
Phil Miller [Tue, 14 Jul 2009 20:29:35 +0000 (15:29 -0500)]
MSA: Fix some 3D Accumulation errors

11 years agoMSA: Accumulate in a 3D array should take 3 indices
Phil Miller [Tue, 14 Jul 2009 19:03:07 +0000 (14:03 -0500)]
MSA: Accumulate in a 3D array should take 3 indices

11 years agoMSA: Partial split-phase synchronization support for 3D arrays
Phil Miller [Mon, 13 Jul 2009 17:40:26 +0000 (12:40 -0500)]
MSA: Partial split-phase synchronization support for 3D arrays

11 years agoMSA: Bring 3D up to reversions in 1D
Phil Miller [Mon, 13 Jul 2009 16:01:05 +0000 (11:01 -0500)]
MSA: Bring 3D up to reversions in 1D

11 years agoRevert creation of page array in cache group constructor
Phil Miller [Sun, 12 Jul 2009 22:21:36 +0000 (17:21 -0500)]
Revert creation of page array in cache group constructor

The 'refactoring' that I did treated these constructors as sequential
code, when it's really being called on each PE. Making a page array
per PE was not the intended effect.

11 years agoRevert "Remove setCacheProxy entry method from PageArray"
Phil Miller [Sun, 12 Jul 2009 22:07:28 +0000 (17:07 -0500)]
Revert "Remove setCacheProxy entry method from PageArray"

This reverts commit 8c3894674485ef32220f559b2a9a2200563306b7.

That commit was dumb, because it was based on an invalid creation structure for the various arrays. I was thinking serially, not parallel-y

11 years agoMSA: Beginnings of split-phase synchronization
Phil Miller [Sun, 12 Jul 2009 18:42:49 +0000 (13:42 -0500)]
MSA: Beginnings of split-phase synchronization

11 years ago3D MSA compiles
Phil Miller [Fri, 10 Jul 2009 00:05:30 +0000 (19:05 -0500)]
3D MSA compiles

11 years agoRevised MSA API stuff
Phil Miller [Thu, 9 Jul 2009 20:17:29 +0000 (15:17 -0500)]
Revised MSA API stuff

11 years agoPartially revised MD example
Phil Miller [Wed, 29 Apr 2009 17:33:32 +0000 (12:33 -0500)]
Partially revised MD example

11 years agoMake the MSA accumulation operations callable without an instance
Phil Miller [Wed, 29 Apr 2009 17:27:21 +0000 (12:27 -0500)]
Make the MSA accumulation operations callable without an instance

11 years agoEnforce operations a bit more through handles
Phil Miller [Wed, 29 Apr 2009 17:25:26 +0000 (12:25 -0500)]
Enforce operations a bit more through handles

11 years agoMerge
Phil Miller [Mon, 20 Apr 2009 17:49:06 +0000 (12:49 -0500)]
Merge

11 years agoRemove setCacheProxy entry method from PageArray
Phil Miller [Thu, 26 Feb 2009 23:44:45 +0000 (17:44 -0600)]
Remove setCacheProxy entry method from PageArray

Pass the CacheGroup proxy to the PageArray constructor instead.

11 years agoFully disable copy constructors for MSA handles
Phil Miller [Tue, 10 Feb 2009 21:54:04 +0000 (15:54 -0600)]
Fully disable copy constructors for MSA handles

Replace the inline definitions of the MSA[12]D::Handle copy
constructors with simple declarations, so that the compiler correctly
treats them as unimplemented.

11 years agoUse typedefs in place of long templated classes
Phil Miller [Tue, 10 Feb 2009 21:52:59 +0000 (15:52 -0600)]
Use typedefs in place of long templated classes

Every class in the MSA implementation has a few typedefs to make life
worth living when expressing function parameters. We ought to use
them.

11 years agoRemove PageArray typedef from exposed MSA class
Phil Miller [Mon, 9 Feb 2009 19:36:12 +0000 (13:36 -0600)]
Remove PageArray typedef from exposed MSA class

The external MSA class no longer deals with the page array at all, so
remove the typedef for it.

11 years agoFactor pageArray creation into CacheGroup's constructor
Phil Miller [Mon, 9 Feb 2009 18:22:51 +0000 (12:22 -0600)]
Factor pageArray creation into CacheGroup's constructor

The MSA class never needs to know anything about the underlying page
array, so it shouldn't be responsible for creating it, passing it to
the CacheGroup, and telling it about the CacheGroup. Make the
CacheGroup do that instead.

11 years agoReformat so that I don't claw out my eyes
Phil Miller [Fri, 6 Feb 2009 21:53:55 +0000 (15:53 -0600)]
Reformat so that I don't claw out my eyes

- Format msa-DistPageMgr.h in stroustrup style, and tell emacs to
  maintain that.
- Fix a spelling error and some absurdly long lines. 80 is not enough,
  but the 120 I can fit across my smaller monitor ought to be.

11 years agoSimplify and start to reorganize msa-DistPageMgr.h
Phil Miller [Fri, 6 Feb 2009 21:33:18 +0000 (15:33 -0600)]
Simplify and start to reorganize msa-DistPageMgr.h

- Merge the unused/referenced MSA_Page_State superclass into its child
- Unduplicate code in MSA_PageT constructor

11 years agoMerge MSA_Page_State into MSA_Page_StateT
Phil Miller [Thu, 5 Feb 2009 22:22:51 +0000 (16:22 -0600)]
Merge MSA_Page_State into MSA_Page_StateT

The non-templated MSA_Page_State had no uses other than as a parent
class for the templated MSA_Page_StateT. Its members are moved over,
and the parent class deleted.

11 years agoRemove duplicated code that broke moldyn.C's build
Phil Miller [Wed, 4 Feb 2009 21:47:29 +0000 (15:47 -0600)]
Remove duplicated code that broke moldyn.C's build

11 years agoAbstract the interface to the MSA page replacement policies
Phil Miller [Wed, 4 Feb 2009 19:59:38 +0000 (13:59 -0600)]
Abstract the interface to the MSA page replacement policies

11 years agoTemplate MSA's page replacement policies over entry type and page size
Phil Miller [Wed, 4 Feb 2009 19:44:30 +0000 (13:44 -0600)]
Template MSA's page replacement policies over entry type and page size

11 years agoMSA_CacheGroup's constructor is pure initialization
Phil Miller [Wed, 4 Feb 2009 01:13:32 +0000 (19:13 -0600)]
MSA_CacheGroup's constructor is pure initialization

Move all the assignment from MSA_CacheGroup's constructor body to its
initializer list, so that it's clear there's no heavy lifting
involved.

11 years agoConvert page and page state arrays into vectors
Phil Miller [Wed, 4 Feb 2009 01:01:15 +0000 (19:01 -0600)]
Convert page and page state arrays into vectors

Stop manually allocating and managing memory for the pointers to pages
and their associated state information. std::vector is quite nice, and
leaves room for adaptivity (i.e. varying number of pages) in the
future with potentially lower overhead.

11 years agoMatch fixedlength_bitvector's interface to std::bitset
Phil Miller [Wed, 4 Feb 2009 00:24:45 +0000 (18:24 -0600)]
Match fixedlength_bitvector's interface to std::bitset

Maybe this could ease a future conversion.

11 years agoPrivatize implementation of MSA_Page_StateT
Phil Miller [Wed, 4 Feb 2009 00:11:39 +0000 (18:11 -0600)]
Privatize implementation of MSA_Page_StateT

Don't expose the use of a bitset, and espcially not the ugly hackish
typedefs involved in doing so. Mark conversion to bitset as a TODO.

11 years agoRemove mymin function
Phil Miller [Tue, 3 Feb 2009 22:35:59 +0000 (16:35 -0600)]
Remove mymin function

It was unused and duplicative

11 years agoDon't do 'using namespace std;' in an MSA header
Phil Miller [Tue, 3 Feb 2009 22:29:05 +0000 (16:29 -0600)]
Don't do 'using namespace std;' in an MSA header

Add std:: qualification to the 4 lines where it's necessary, rather
than dumping all of the standard namespace into scope in a header.

11 years agoTypo fix: mathod -> method
Phil Miller [Tue, 3 Feb 2009 22:22:25 +0000 (16:22 -0600)]
Typo fix: mathod -> method

11 years agoTests: Fix lone build error on Ubuntu 9.10
Phil Miller [Thu, 10 Dec 2009 21:24:58 +0000 (15:24 -0600)]
Tests: Fix lone build error on Ubuntu 9.10

11 years agoMPI: default to using the more common mpicxx instead of mpiCC
Phil Miller [Thu, 10 Dec 2009 18:40:10 +0000 (12:40 -0600)]
MPI: default to using the more common mpicxx instead of mpiCC

11 years agoTracing: _TRACE_ONLY is already contingent on !CMK_OPTIMIZE
Phil Miller [Thu, 10 Dec 2009 18:29:09 +0000 (12:29 -0600)]
Tracing: _TRACE_ONLY is already contingent on !CMK_OPTIMIZE

11 years agocharmxi: Lots of additional const qualification
Phil Miller [Thu, 10 Dec 2009 17:41:56 +0000 (11:41 -0600)]
charmxi: Lots of additional const qualification

Quiet a warning in charmxi compilation, and propagate a whole bunch of
const-ness fixes in the process.

11 years agoremoved obsolete -Wno-long-double
Gengbin Zheng [Thu, 10 Dec 2009 16:22:46 +0000 (10:22 -0600)]
removed obsolete -Wno-long-double

11 years agofixed lib path for mpi library to be friendly with unix (unix2nt_cc will handle the...
Gengbin Zheng [Thu, 10 Dec 2009 07:49:43 +0000 (01:49 -0600)]
fixed lib path for mpi library to be friendly with unix (unix2nt_cc will handle the unix to dos path conversion)

via git-CVS emulator

11 years agoAdded handling of phases in projections instrumentation.
Chee Wai Lee [Thu, 10 Dec 2009 07:13:48 +0000 (01:13 -0600)]
Added handling of phases in projections instrumentation.

Added latest version of online cluster analysis code. This has not been
fully tested for correctness, but will produce results. The correctness
of basic projections tracing and analysis has not been compromised.

11 years agoreverted the previous change in make dependency
Gengbin Zheng [Thu, 10 Dec 2009 06:58:32 +0000 (00:58 -0600)]
reverted the previous change in make dependency

11 years agoMerge commit 'charm/charm' into charm
Filippo Gioachin [Thu, 10 Dec 2009 02:13:34 +0000 (20:13 -0600)]
Merge commit 'charm/charm' into charm