Charj: Removal of automatic promotion of pointer to object in entry methods.
authorJonathan Lifflander <jliffl2@illinois.edu>
Sat, 3 Jul 2010 21:41:59 +0000 (16:41 -0500)
committerJonathan Lifflander <jliffl2@illinois.edu>
Sat, 3 Jul 2010 21:41:59 +0000 (16:41 -0500)
The method that promotes pointer types to object types in entry method parameters
is not working correctly. It was causing the Array pointers to be converted to
objects, which was breaking them in the chare/mainchare case. This code/methodology
is going to be rewritten at some point.

src/langs/charj/src/charj/translator/CharjASTModifier.g

index 3e8dcc70fb70a143335a90161b83193535fa413c..513f67a24d12b05eb026a4e11e1250e90d0211d8 100644 (file)
@@ -239,7 +239,10 @@ objectType
     |   ^(REFERENCE_TYPE qualifiedTypeIdent domainExpression?)
     |   ^(POINTER_TYPE qualifiedTypeIdent domainExpression?)
         {
-            astmod.dealWithEntryMethodParam($POINTER_TYPE, $POINTER_TYPE.tree);
+            // TODO: This breaks all pointer types inside chares not used for sending
+            // them in entry methods, converting them to object types, which breaks
+            // Arrays inside chares.
+            //astmod.dealWithEntryMethodParam($POINTER_TYPE, $POINTER_TYPE.tree);
         }
     ;